[PM-9439] Use passkey icon for items with FIDO2 credentials in search results #4541
Conversation
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
| @@ -247,7 +248,7 @@ private fun CipherView.toIconData( | |||
| login?.uris.toLoginIconData( | |||
| baseIconUrl = baseIconUrl, | |||
| isIconLoadingDisabled = isIconLoadingDisabled, | |||
| usePasskeyDefaultIcon = false, | |||
| usePasskeyDefaultIcon = this.isActiveWithFido2Credentials, | |||
There was a problem hiding this comment.
Are there any tests that need updating for this?
There was a problem hiding this comment.
I couldn't find any that are specifically checking the fallback icon although it says it's hit in my local coverage report. I was hoping CodeCov would find something but it has gone radio silent for some reason. I'm thinking my local report is a false positive so I'm adding one explicitly for it.
SaintPatrck
force-pushed
the
PM-9439/passkey-icon-in-search-list
branch
from
087e2d0 to
ec7a12f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4541 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 460 460
Lines 39940 39940
Branches 5691 5691
=======================================
Hits 35497 35497
Misses 2459 2459
Partials 1984 1984 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
PM-9439
📔 Objective
Display the passkey icon for search results that contain FIDO2 credentials when the web icon is unavailable.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes