Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14179: Update generator screen copy button #4530

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Jan 7, 2025

🎟️ Tracking

PM-14179

📔 Objective

This PR moves the password copy button down and make it more pronounces as well as updates the BitwardenTextField to allow for nullable labels.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One – Scan Summary & Details119d73be-fd7c-44a7-af1b-a367c0f39203

No New Or Fixed Issues Found

@david-livefront david-livefront force-pushed the PM-14179-generator-update branch from 0f147ac to 08c87ee Compare January 7, 2025 23:01
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (9c2a902) to head (08c87ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4530   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         460      460           
  Lines       39912    39917    +5     
  Branches     5690     5690           
=======================================
+ Hits        35468    35474    +6     
+ Misses       2458     2457    -1     
  Partials     1986     1986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-livefront
Copy link
Collaborator Author

Thanks @SaintPatrck

@david-livefront david-livefront added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit bb66150 Jan 8, 2025
8 checks passed
@david-livefront david-livefront deleted the PM-14179-generator-update branch January 8, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants