Clean up the generator screen and handlers #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
david-livefront
commented
Nov 8, 2024
| ) { | ||
| BitwardenTopAppBar( | ||
| title = stringResource(id = R.string.generator), | ||
| navigationIcon = rememberVectorPainter(id = R.drawable.ic_close), | ||
| navigationIconContentDescription = stringResource(id = R.string.close), | ||
| onNavigationIconClick = onCloseClick, | ||
| scrollBehavior = scrollBehavior, | ||
| dividerStyle = when (generatorMode) { | ||
| GeneratorMode.Modal.Password -> TopAppBarDividerStyle.NONE | ||
| is GeneratorMode.Modal.Username -> TopAppBarDividerStyle.ON_SCROLL |
There was a problem hiding this comment.
This is the only change that affects the UI, previously, the divider would appear on the top app bar and the segmented control and it should only be on the segmented control.
david-livefront
force-pushed
the
generator-cleanup
branch
from
5de6306 to
72e75fa
Compare
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4270 +/- ##
=======================================
Coverage 88.97% 88.98%
=======================================
Files 445 452 +7
Lines 38887 38913 +26
Branches 5468 5469 +1
=======================================
+ Hits 34601 34627 +26
Misses 2369 2369
Partials 1917 1917 ☔ View full report in Codecov by Sentry. |
david-livefront
force-pushed
the
generator-cleanup
branch
from
72e75fa to
c1b1875
Compare
|
Thanks @dseverns-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
N/A
📔 Objective
This PR moves all of the handler classes from the
GeneratorScreenand into their own files.Some other small changes were made to the
GeneratorScreenbut none affect the app functionality.There is one minor UI update, the divider line is no longer displayed when in the generator modal and the segmented control is present.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes