PM-14433: Null domain data #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4268 +/- ##
==========================================
- Coverage 88.98% 88.97% -0.02%
==========================================
Files 445 445
Lines 38852 38852
Branches 5458 5461 +3
==========================================
- Hits 34574 34570 -4
Misses 2369 2369
- Partials 1909 1913 +4 ☔ View full report in Codecov by Sentry. |
SaintPatrck
force-pushed
the
cherrypick/hotfix-25097cba-to-main
branch
from
da9f3e4 to
eb03add
Compare
SaintPatrck
force-pushed
the
cherrypick/hotfix-25097cba-to-main
branch
from
eb03add to
a2cbf7e
Compare
david-livefront
approved these changes
Nov 8, 2024
app/schemas/com.x8bit.bitwarden.data.vault.datasource.disk.database.VaultDatabase/4.json
Outdated
Show resolved
Hide resolved
| @@ -121,12 +121,12 @@ class VaultDiskSourceImpl( | |||
| }, | |||
| ) | |||
|
|
|||
| override fun getDomains(userId: String): Flow<SyncResponseJson.Domains> = | |||
| override fun getDomains(userId: String): Flow<SyncResponseJson.Domains?> = | |||
| domainsDao | |||
| .getDomains(userId) | |||
There was a problem hiding this comment.
This needs to be rebased and then address this issue: https://github.com/bitwarden/android/pull/4263/files#r1834799472
david-livefront
requested changes
Nov 8, 2024
SaintPatrck
force-pushed
the
cherrypick/hotfix-25097cba-to-main
branch
from
a2cbf7e to
2d81960
Compare
app/src/main/java/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt
Outdated
Show resolved
Hide resolved
SaintPatrck
force-pushed
the
cherrypick/hotfix-25097cba-to-main
branch
from
2d81960 to
283c353
Compare
SaintPatrck
force-pushed
the
cherrypick/hotfix-25097cba-to-main
branch
from
efe33a7 to
a0434ff
Compare
david-livefront
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14433
Cherry-picked from #4243 (25097cb) on branch
release/hotfix-v2024.11.1.📔 Objective
This PR allows for the domains data to be nullable in the sync response JSON and handles all the downstream affects that change has.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes