PM-14379: Stop storing 'null' in as the word separator #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-livefront
requested review from
brian-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
david-livefront
commented
Nov 1, 2024
| @@ -462,7 +462,7 @@ class GeneratorViewModel @Inject constructor( | |||
| val newOptions = options.copy( | |||
| type = PasscodeGenerationOptions.PasscodeType.PASSPHRASE, | |||
| numWords = passphrase.numWords, | |||
| wordSeparator = passphrase.wordSeparator.toString(), | |||
| wordSeparator = passphrase.wordSeparator?.toString().orEmpty(), | |||
There was a problem hiding this comment.
Without the ?, we would stor the full word null as the separator
david-livefront
commented
Nov 1, 2024
| @@ -351,7 +351,7 @@ class GeneratorViewModel @Inject constructor( | |||
| GeneratorState.MainType.Passphrase( | |||
| numWords = max(options.numWords, minNumWords), | |||
| minNumWords = minNumWords, | |||
| wordSeparator = options.wordSeparator.toCharArray().first(), | |||
| wordSeparator = options.wordSeparator.toCharArray().firstOrNull(), | |||
There was a problem hiding this comment.
Since the string can now be blank, we use null in that case.
|
Thanks @dseverns-livefront |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
==========================================
- Coverage 89.05% 89.05% -0.01%
==========================================
Files 445 445
Lines 38653 38653
Branches 5402 5403 +1
==========================================
- Hits 34422 34421 -1
Misses 2357 2357
- Partials 1874 1875 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14379
📔 Objective
This PR fixes a bug where we were storing the word
nullas the word separator which caused the value to default to the first char,n.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes