[PM-14186] Update SDK to make SSH key properties required #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the handling of SSH key fields (publicKey, privateKey, fingerprint) to treat them as non-nullable.
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4200 +/- ##
==========================================
- Coverage 89.09% 89.06% -0.03%
==========================================
Files 445 445
Lines 38645 38642 -3
Branches 5406 5403 -3
==========================================
- Hits 34430 34418 -12
- Misses 2343 2351 +8
- Partials 1872 1873 +1 ☔ View full report in Codecov by Sentry. |
| fingerprint = "fingerprint".takeUnless { isEmpty }, | ||
| privateKey = "privateKey".takeUnless { isEmpty } ?: "", | ||
| publicKey = "publicKey".takeUnless { isEmpty } ?: "", | ||
| fingerprint = "fingerprint".takeUnless { isEmpty } ?: "", |
There was a problem hiding this comment.
So is the SshKeyView requiring the values to be nonnull too?
There was a problem hiding this comment.
I see, can we use orEmpty()?
SaintPatrck
changed the title
david-livefront
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14186
📔 Objective
Update Bitwarden SDK to the latest version.
This change updates the handling of SSH key fields (publicKey, privateKey, fingerprint) to treat them as non-nullable.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes