Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-13842: Hide ownership when the user has no organizations #4199

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 30, 2024

🎟️ Tracking

PM-13842

📔 Objective

This PR removes the ownership section for the create cipher UI when there are no organizations to select from.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront force-pushed the PM-13842-hide-ownership branch from 6daa619 to c685f92 Compare October 30, 2024 15:55
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@fab0187). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../ui/vault/feature/addedit/VaultAddEditCardItems.kt 0.00% 0 Missing and 1 partial ⚠️
...vault/feature/addedit/VaultAddEditIdentityItems.kt 0.00% 0 Missing and 1 partial ⚠️
...ui/vault/feature/addedit/VaultAddEditLoginItems.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4199   +/-   ##
=======================================
  Coverage        ?   89.07%           
=======================================
  Files           ?      445           
  Lines           ?    38643           
  Branches        ?     5406           
=======================================
  Hits            ?    34421           
  Misses          ?     2349           
  Partials        ?     1873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dseverns-livefront dseverns-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-livefront
Copy link
Collaborator Author

Thanks @dseverns-livefront

@david-livefront david-livefront added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit c99e5ce Oct 30, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-13842-hide-ownership branch October 30, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants