[PM-12406] Introduce new endpoint and replace SSO details response flow #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rganizationService
… SSO Login flow. Feature flag also used.
andrebispo5
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4177 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 445 445
Lines 38645 38695 +50
Branches 5403 5412 +9
=======================================
+ Hits 34414 34460 +46
- Misses 2357 2359 +2
- Partials 1874 1876 +2 ☔ View full report in Codecov by Sentry. |
app/src/main/res/values/strings.xml
Outdated
| @@ -1073,4 +1073,5 @@ Do you want to switch to this account?</string> | |||
| <string name="bitwarden_tools">Bitwarden Tools</string> | |||
| <string name="got_it">Got it</string> | |||
| <string name="no_logins_were_imported">No logins were imported</string> | |||
| <string name="verified_sso_domain_verified">Verified Sso Domain Endpoint</string> | |||
There was a problem hiding this comment.
Should Sso be all caps?
|
|
||
| @Suppress("MaxLineLength") | ||
| @Test | ||
| fun `getVerifiedOrganizationDomainSsoDetails when response is success should return valid response`() = runTest { |
There was a problem hiding this comment.
The formatter should move the runTest { down a line if it's past the line limit
# Conflicts: # app/src/main/res/values/strings.xml
| @Suppress("MaxLineLength") | ||
| @Test | ||
| fun `getVerifiedOrganizationDomainSsoDetails when response is success should return valid response`() = | ||
| runTest { |
There was a problem hiding this comment.
You should re-run the formatter here, all the indentation is off
There was a problem hiding this comment.
Sorry thought I had it running automatically. Fixed now. 👍
david-livefront
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
[PM-12406 Introduce new endpoint and replace SSO details response flow](https://bitwarden.atlassian.net/browse/PM-12406)
📔 Objective
In order to align the back-end contract with the front-end expectations, add a net-new GET verified domains flow.
We will keep the original SSO details flow in place, this new implementation will be behind a remote feature flag.
📸 Screenshots
Screen.Recording.2024-10-28.at.16.38.59.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes