Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13908] Disable ExtraTranslation lint warning #4176

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13908

📔 Objective

This commit disables the ExtraTranslation lint warning.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

This commit disables the `ExtraTranslation` lint warning.
@SaintPatrck SaintPatrck changed the title Disable ExtraTranslation lint warning [PM-13908] Disable ExtraTranslation lint warning Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (064db9f) to head (21b41f6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4176   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         439      439           
  Lines       38099    38099           
  Branches     5336     5336           
=======================================
  Hits        33891    33891           
  Misses       2346     2346           
  Partials     1862     1862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck enabled auto-merge October 28, 2024 16:50
@SaintPatrck SaintPatrck added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit deb9eb8 Oct 28, 2024
9 checks passed
@SaintPatrck SaintPatrck deleted the crowdin/ignore-extra-translations-lint-error branch October 28, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants