Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14009 complete fix importlogins card show logic #4175

Merged

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Oct 28, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14009

📔 Objective

  • Only show "Vault settings/Import logins" badge and action card if the user dismisses the card in their vault/chooses the "import later" option.

📸 Screenshots

pm14009.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (eb4ffeb) to head (29a5667).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ata/platform/manager/FirstTimeActionManagerImpl.kt 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4175   +/-   ##
=======================================
  Coverage   88.94%   88.95%           
=======================================
  Files         439      439           
  Lines       38078    38113   +35     
  Branches     5334     5336    +2     
=======================================
+ Hits        33870    33903   +33     
- Misses       2346     2347    +1     
- Partials     1862     1863    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 21a5242 Oct 28, 2024
7 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-14009-complete-fix-importlogins-card-show-logic branch October 28, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants