QA-954: Add testtags to Send screen elements #4162
Conversation
ifernandezdiaz
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
| modifier = Modifier.semantics { | ||
| increaseButtonTestTag?.let { testTag = it } | ||
| }, | ||
| modifier = Modifier.testTag("IncrementValue"), |
There was a problem hiding this comment.
What about the custom test tag?
There was a problem hiding this comment.
Since we consider the Stepper a component, we require a fixed ID for each inner element (Increment/Decrease buttons, inner text field, etc.).
That's why I made that change. Does it affect your UI unit tests?
There was a problem hiding this comment.
No, our tests should be fine. We never use test tags in unit tests since they make for a weaker test.
But can you remove the increaseButtonTestTag and decreaseButtonTestTag params if they are no longer needed.
There was a problem hiding this comment.
You removed the properties but did not update all the places that call those properties
There was a problem hiding this comment.
My bad! Fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4162 +/- ##
==========================================
- Coverage 88.95% 88.95% -0.01%
==========================================
Files 439 439
Lines 38080 38075 -5
Branches 5336 5336
==========================================
- Hits 33874 33869 -5
Misses 2346 2346
Partials 1860 1860 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
📔 Objective
This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes