QA-952: Adding test tags for Toggle items #4153
Conversation
ifernandezdiaz
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 437 437
Lines 37938 37938
Branches 5324 5324
=======================================
Hits 33735 33735
Misses 2347 2347
Partials 1856 1856 ☔ View full report in Codecov by Sentry. |
| @@ -100,7 +102,8 @@ fun BitwardenWideSwitch( | |||
|
|
|||
| Switch( | |||
| modifier = Modifier | |||
| .height(56.dp), | |||
| .height(56.dp) | |||
| .testTag("SwitchToggle"), | |||
There was a problem hiding this comment.
This seems way to generic, most of the places we use the switch already have the test tags.
There was a problem hiding this comment.
I decided to add this generic ID at the component level due to a refactor we made on the automation side.
Now, each Switch element will contain its name label and toggle element, making most of our validations easier
There was a problem hiding this comment.
I see, what about the description?
ifernandezdiaz
deleted the
QA-952/adding-testTags-for-collection-list-items
branch
🎟️ Tracking
📔 Objective
This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes