-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure change #3
base: main
Are you sure you want to change the base?
Conversation
Can you remove the I recommend using a good global |
Removed cache files and added a .gitignore file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I left a few comments to mainly update some of the code style a bit. Note that some of these comments re-occur in a few different places but I haven't marked all of them, so go through the code with them in mind.
Resolved all comments, updated the base algorithm of food counts computation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is starting to look very nice, good job. I have one main concern, and that's the addition of several big(ish) sample files used for testing. This should ideally be avoided, see the comment in the code.
Solved previous comments, and 8/11 issues. Issues remaining are to add changelog, documentation and contributing guidelines |
Changed structure of the package(added classes for food counts and food flows), added visualization, utilities and testing