Add BSIP 34: Always Trigger Margin Call When Call Price Above Or At Price Feed #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
reviewed
Feb 18, 2018
bsip-0034.md
Outdated
| feed is usually considered trustworthy. On the other hand, instant market | ||
| price is not as reliable, especially for the markets with poor depth, so it's | ||
| a rather limited supplement for calculating collateral price. Depth of internal | ||
| markets could be greatly improved in the future, however price feed producers |
There was a problem hiding this comment.
Bad idea, please remove the last sentence of this paragraph. (Or leave it in if you disagree, this PR is not about discussing the BSIP.)
pmconrad
reviewed
Feb 18, 2018
| Replaces: - | ||
| Worker: To be done | ||
|
|
||
| # Abstract |
There was a problem hiding this comment.
Most of this abstract belongs in the Motivation section IMO.
xeroc
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSIP for bitshares/bitshares-core#606.