Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace int with 64-bit types in static_variant #195

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

abitmore
Copy link
Member

No description provided.

@abitmore abitmore added this to the core release 4.0.0 milestone Mar 29, 2020
@abitmore
Copy link
Member Author

Although it's theoretically possible that there exists issues on conversion between signed integer and unsigned integer, practically we won't have a huge type list in static_variant, thus count() will always be much much smaller than maximum value of int64_t. In other words, it won't overflow. Probably we can add a static_assert somewhere to be safer.

@abitmore abitmore merged commit 907a81b into for-core-4.0.x Mar 31, 2020
@abitmore abitmore deleted the replace-int-in-static-variant branch March 31, 2020 15:41
abitmore added a commit to bitshares/bitshares-core that referenced this pull request Apr 6, 2020
- bitshares/bitshares-fc#192 Update bool serialization
- bitshares/bitshares-fc#193 Fix potential infinity loop in `exception::to_detail_string()`
- bitshares/bitshares-fc#194 Update to_variant(size_t) for macOS and OpenBSD
- bitshares/bitshares-fc#195 Replace int with 64-bit types in static_variant
- bitshares/bitshares-fc#196 Fix compiler warnings about static_variant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant