Unit test + log message related to issue #338

libraries/chain/db_market.cpp

@@ -530,6 +530,8 @@ bool database::check_call_orders(const asset_object& mia, bool enable_black_swan
           order_pays     = usd_to_buy;
 
           filled_call    = true;
+          if( filled_limit )
+             wlog( "Multiple limit match problem (issue 338) occurred at block #${block}", ("block",head_block_num()) );
        }
 
        FC_ASSERT( filled_call || filled_limit );

tests/common/database_fixture.cpp

@@ -709,6 +709,26 @@ const limit_order_object* database_fixture::create_sell_order( const account_obj
    return db.find<limit_order_object>( processed.operation_results[0].get<object_id_type>() );
 }
 
+//APM --> (for TESTS, adds above1 flag via expiration field in order to indicate if expected order price is trading above or below 1
+const limit_order_object* database_fixture::create_sell_order_with_flag( const account_object& user, const asset& amount, const asset& recv, bool above1 )
+{
+   //wdump((amount)(recv));
+   limit_order_create_operation buy_order;
+   buy_order.seller = user.id;
+   buy_order.amount_to_sell = amount;
+   buy_order.min_to_receive = recv;
+   if (above1) buy_order.expiration = buy_order.expiration.maximum()-1000; else 
+		buy_order.expiration = buy_order.expiration.maximum()-1001;
+   trx.operations.push_back(buy_order);
+   for( auto& op : trx.operations ) db.current_fee_schedule().set_fee(op);
+   trx.validate();
+   auto processed = db.push_transaction(trx, ~0);
+   trx.operations.clear();
+   verify_asset_supplies(db);
+   //wdump((processed));
+   return db.find<limit_order_object>( processed.operation_results[0].get<object_id_type>() );
+}
+
 asset database_fixture::cancel_limit_order( const limit_order_object& order )
 {
   limit_order_cancel_operation cancel_order;

tests/common/database_fixture.hpp

@@ -263,6 +263,7 @@ struct database_fixture {
    void sign( signed_transaction& trx, const fc::ecc::private_key& key );
    const limit_order_object* create_sell_order( account_id_type user, const asset& amount, const asset& recv );
    const limit_order_object* create_sell_order( const account_object& user, const asset& amount, const asset& recv );
+   const limit_order_object* create_sell_order_with_flag( const account_object& user, const asset& amount, const asset& recv, bool above1 );
    asset cancel_limit_order( const limit_order_object& order );
    void transfer( account_id_type from, account_id_type to, const asset& amount, const asset& fee = asset() );
    void transfer( const account_object& from, const account_object& to, const asset& amount, const asset& fee = asset() );