Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticSearch related code refactory #2576

Merged
merged 17 commits into from
Jan 18, 2022
Merged

ElasticSearch related code refactory #2576

merged 17 commits into from
Jan 18, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Jan 10, 2022 •
edited
Loading

Refactored code mainly in the sense of object-oriented programming.

BTW here is an interesting error during development. -_-!

.../elasticsearch.hpp:47:7: error: expected identifier before ‘(’ token
   47 |       DELETE  = 4,
      |       ^~~~~~

In Win32, DELETE is a macro used for dealing with ACLs (access control lists). (link)

@abitmore abitmore added this to the 6.1.0 - Feature Release milestone Jan 10, 2022
@abitmore abitmore marked this pull request as ready for review January 16, 2022 23:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

75.4% 75.4% Coverage
0.0% 0.0% Duplication

@abitmore abitmore merged commit c09bb5c into develop Jan 18, 2022
@abitmore abitmore deleted the es-refactory branch January 18, 2022 14:52
@abitmore abitmore mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0 - Feature Release
Development

Successfully merging this pull request may close these issues.
1 participant
@abitmore