Add who was selling what to trade APIs #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
reviewed
May 14, 2020
abitmore
reviewed
May 15, 2020
|
A rerun of Github Auto Actions failed, probably due to actions/checkout#23. Update: hopefully it will be fixed by #2177. |
17 tasks
abitmore
reviewed
May 21, 2020
abitmore
approved these changes
May 22, 2020
There was a problem hiding this comment.
Code looks good. Thanks.
Github Autobuild for Ubuntu debug mode is failing due to disk space issue (it's strange that /mnt has 2.2G space used already), will try to get around it via #2178 anyway.
Docker cloud is not working right now, don't know why. Will retry later.
|
Thanks, merged to a temporary branch and cherry-picked to #2181 for 4.0 release. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged it will close #2163