Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly create config.ini for delayed_node #1988

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

jmjatlanta
Copy link
Contributor

@jmjatlanta jmjatlanta commented Sep 11, 2019

Fixes #1986

options were added to the configuration too many times, resulting in duplicates within the config.ini file. This fixes the problem for delayed_node.

Note: The code is very similar for witness_node, but seems to work correctly.

@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Sep 11, 2019
Copy link
Contributor

@pmconrad pmconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

The difference between delayed_node and witness_node lies in the way that the config.ini file is created. It seems delayed_node still uses the old code that doesn't de-duplicate config items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants