Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matrix Build Support to Travis-CI Integration #1416

Closed
wants to merge 1 commit into from

Conversation

marcialvieira
Copy link
Contributor

@marcialvieira marcialvieira commented Nov 2, 2018

Fix for #1233

@oxarbitrage
Copy link
Member

Hey @marcialvieira thank you for submitting this.

I am unsure if we can use it with our current limitation of 50 minutes max in travis. We are in the process of merging #1417 that will speed up a bit but probably not enough to make the build for 2 Operation Systems as this pull attempt to do.

Still, i am considering and discussing with the team a possible upgrade in travis to a paid plan that will allow unlimited build time.

@marcialvieira
Copy link
Contributor Author

Hi, thanks for replying, maybe some modifications can also be made to reduce compilation time, increasing the number of jobs (I mean -j), but this will increase memory usage and may abort because of that, change from Debug to Release, so debug symbols don't be added, add some parameters like -pipe or switch compiler, to clang for example.

@pmconrad
Copy link
Contributor

pmconrad commented Mar 1, 2019

Please rebase on latest develop.
The osx build has failed, please check.

@marcialvieira
Copy link
Contributor Author

Working on it.

@marcialvieira
Copy link
Contributor Author

Job aborted for time limit during the test, but reading the logs I'm convinced that everything is fine marcialvieira/bitshares-core

@marcialvieira marcialvieira force-pushed the 1233-travis branch 3 times, most recently from d569d44 to 225e5cb Compare March 2, 2019 03:56
@pmconrad
Copy link
Contributor

pmconrad commented Mar 2, 2019

Test setup error: boost::runtime::access_to_missing_argument: There is no argument provided for parameter color_output

This does not look good. Possible cause: https://stackoverflow.com/questions/39171467/there-is-no-argument-provided-for-parameter-color-output-with-boost-test-and-cte

Can you reproduce this locally? @jmjatlanta did you ever see that?

Maybe need to add code like this to tests/CMakeLists.txt: https://github.com/bitshares/bitshares-fc/blob/master/CMakeLists.txt#L411-L417

@jmjatlanta
Copy link
Contributor

jmjatlanta commented Mar 4, 2019

I have not seen that before. I will attempt to recreate it on my mac.

Update I compiled and ran chain_test on my mac with no errors. I then noticed the travis script is using gnu parallel. I re-ran it using parallel, but am still unable to reproduce the error.

@pmconrad
Copy link
Contributor

pmconrad commented Mar 4, 2019

Perhaps it depends on boost version?

@marcialvieira
Copy link
Contributor Author

Yeah, looking into it.

@marcialvieira
Copy link
Contributor Author

marcialvieira commented Mar 4, 2019

Giving a try without installing [email protected], using the default travis-ci image (boost 1.67.0_1) since @jmjatlanta told me that he successfully built using 1.68 on his mac.

Update same problem, now testing defining BOOST_TEST_DYN_LINK in tests/CMakeLists.txt as @pmconrad said.

Update still the same, but now I have been able to reproduce locally.

@marcialvieira marcialvieira force-pushed the 1233-travis branch 2 times, most recently from 05a27fd to 02736a2 Compare March 4, 2019 19:43
@pmconrad pmconrad added this to the 3.2.0 - Feature Release milestone Apr 29, 2019
@abitmore abitmore removed this from the Future Feature Release milestone Mar 18, 2021
@abitmore
Copy link
Member

Obsolete by #2062 and following changes. Our main CI process is now on Github Actions.

@abitmore abitmore closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants