Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar integration into travis build #1081

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Sonar integration into travis build #1081

merged 2 commits into from
Jul 18, 2018

Conversation

pmconrad
Copy link
Contributor

@pmconrad pmconrad commented Jun 23, 2018 •
edited
Loading

Fixes #836

Also contains a fix in database::update_global_dynamic_data to speed up counting missed blocks. (This also fixes a minor issue with counting - the previous algorithm would skip missed blocks for the witness who signed the first block after the gap.)

Doesn't work properly before #1087 has been merged, due to unit tests timing out.

@pmconrad pmconrad self-assigned this Jun 23, 2018
@pmconrad pmconrad added 2d Developing Status indicating currently designing and developing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 6 Build Impact flag identifying the build process 6 Performance Impacts flag identifying system/user efficiency, performance, etc. labels Jun 23, 2018
@abitmore
Copy link
Member

About the fix, steemit/steem#2472 (comment)

the witness that produced the first block after revived a halted chain will get a good-looking block missing number which is somewhat a prize. IMHO that's why we didn't "fix" it before.

@abitmore
Copy link
Member

@pmconrad can you please split the fix/performance improvement to a new PR?

abitmore
abitmore previously requested changes Jun 23, 2018
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented above.

@pmconrad pmconrad mentioned this pull request Jun 23, 2018
Closed
17 tasks
@pmconrad
Copy link
Contributor Author

Moved the fix into #1086 / #1087 , rebasing this one

@pmconrad pmconrad force-pushed the 836_sonar_integration branch from 0561bba to 5dad02c Compare June 23, 2018 16:46
@abitmore abitmore dismissed their stale review July 3, 2018 23:02

Stale

@pmconrad pmconrad force-pushed the 836_sonar_integration branch from 5dad02c to 740fd54 Compare July 17, 2018 17:36
@pmconrad
Copy link
Contributor Author

Rebased on current develop
Would like to add cli_test, but it fails

oxarbitrage
oxarbitrage approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, output can be seen at https://sonarcloud.io/project/issues?branch=836_sonar_integration&id=BitShares_Core&resolved=false

@oxarbitrage oxarbitrage merged commit f38492c into bitshares:develop Jul 18, 2018
@oxarbitrage oxarbitrage mentioned this pull request Jul 18, 2018
Closed
@abitmore abitmore mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@abitmore abitmore abitmore left review comments

Assignees

@pmconrad pmconrad

Labels
2d Developing Status indicating currently designing and developing a solution 3c Enhancement Classification indicating a change to the functionality of the existing imlementation 6 Build Impact flag identifying the build process 6 Performance Impacts flag identifying system/user efficiency, performance, etc.
Projects
None yet
Milestone
201808 - Non-Consensus-Changing Release
Development

Successfully merging this pull request may close these issues.
3 participants
@pmconrad @abitmore @oxarbitrage