Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market fees of settle orders aren't shared to referral program #1780

Closed
2 of 17 tasks
abitmore opened this issue May 27, 2019 · 5 comments
Closed
2 of 17 tasks

Market fees of settle orders aren't shared to referral program #1780

abitmore opened this issue May 27, 2019 · 5 comments
Assignees
@abitmore
Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 DEX Impact flag identifying the Decentralized EXchange, market engine, etc. 6 Protocol Impact flag identifying the blockchain logic, consensus, validation, etc. hardfork
Milestone
4.0.0 - Protocol ...

Comments

@abitmore
Copy link
Member

Bug Description
For limit orders:

bitshares-core/libraries/chain/db_market.cpp

Lines 821 to 823 in e3d1226

auto issuer_fees = ( head_block_time() < HARDFORK_1268_TIME ) ?
pay_market_fees(recv_asset, receives) :
pay_market_fees(seller, recv_asset, receives);

For settle orders:

bitshares-core/libraries/chain/db_market.cpp

Line 934 in e3d1226

auto issuer_fees = pay_market_fees(get(receives.asset_id), receives);

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added hardfork 1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 Protocol Impact flag identifying the blockchain logic, consensus, validation, etc. 6 DEX Impact flag identifying the Decentralized EXchange, market engine, etc. labels May 27, 2019
@abitmore abitmore mentioned this issue May 27, 2019
Merged
@OpenLedgerApp
Copy link
Contributor

We have implemented this BSIP. So, we want to keep it on us - we can fix them efficiently.

@ryanRfox
Copy link
Contributor

ryanRfox commented Jun 5, 2019

Yes, @OpenLedgerApp please take this one.

@OpenLedgerApp
Copy link
Contributor

We have made an investigation of settle_order.

The settle orders can be matched only between MIA and Core-asset.
So, in fill_settle_order we always receive Core-asset, that doesn't use Market Fee Sharing.
That way, it not necessary to add Market Fee Sharing functionality in the function fill_settle_order.

Please correct us if we are wrong.

@abitmore
Copy link
Member Author

abitmore commented Jun 28, 2019 •
edited
Loading

The settle orders can be matched only between MIA and Core-asset.

No. You can create a new asset that is backed by another asset which is not CORE, then borrow some, then settle.

@OpenLedgerApp OpenLedgerApp mentioned this issue Jul 8, 2019
Merged
@abitmore abitmore mentioned this issue Apr 5, 2020
Merged
@abitmore abitmore assigned abitmore and unassigned OpenLedgerApp Apr 9, 2020
abitmore added a commit that referenced this issue Apr 9, 2020
@abitmore
Add market fee sharing for instant settlements
c32a4e6 
Pay market fee and share it with the referral program when settling
an amount of a globally settled asset after the core-1780 hard fork,
for issue #1780
@abitmore
Copy link
Member Author

Fixed by #1842 and #2132.

@MichelSantos MichelSantos mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abitmore abitmore

Labels
1b User Story The User Story details a requirement. It may reference a parent Epic. It may reference child Task(s) 3d Bug Classification indicating the existing implementation does not match the intention of the design 6 DEX Impact flag identifying the Decentralized EXchange, market engine, etc. 6 Protocol Impact flag identifying the blockchain logic, consensus, validation, etc. hardfork
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

No branches or pull requests
3 participants
@abitmore @ryanRfox @OpenLedgerApp