Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many things need to be moved to a plugin #116

Open
vikramrajkumar opened this issue Jan 18, 2017 · 1 comment
Open

Many things need to be moved to a plugin #116

vikramrajkumar opened this issue Jan 18, 2017 · 1 comment
Labels

Comments

@vikramrajkumar
Copy link
Contributor

From @theoreticalbts on October 30, 2015 19:42

Things in core that need to move to plugins:

Indexes:

  • account_member_index

Objects:

  • impl_account_transaction_history_object_type
  • impl_witness_schedule_object_type
  • impl_budget_record_object_type
  • remove impl_reserved0_object_type
  • remove custom_object_type
  • operation_history_object_type

Fields:

  • account_object.whitelisted_accounts
  • account_object.blacklisted_accounts
  • witness_object.last_aslot
  • witness_object.url
  • witness_object.total_missed
  • witness_object.last_confirmed_block_num
  • dpo.recent_slots_filled
  • dpo.last_irreversible_block_num
  • dpo.recently_missed_count

Copied from original issue: cryptonomex/graphene#422

@pmconrad
Copy link
Contributor

The usefulness of plugins is currently somewhat limited, because the new_objects, changed_objects and removed_objects callbacks are effectively disabled during a replay. This makes it impossible, for example, to collect certain historic data in a plugin, i. e. everything that is not represented somehow in signed_block.operations.
I'm not sure if this limitation is on purpose. The callbacks mentioned above rely on undo_db, which is disabled during replay for performance reasons. I tested a replay with undo_db enabled, and it took 20% longer than without on the current chain (~19M blocks).

oxarbitrage pushed a commit to oxarbitrage/bitshares-core that referenced this issue Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants