Add note

bitshares · Jan 9, 2023 · ebbb8db · ebbb8db
1 parent 6e56261
commit ebbb8db
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/.github/workflows/build-and-test.ubuntu-debug.yml b/.github/workflows/build-and-test.ubuntu-debug.yml
@@ -9,6 +9,10 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-20.04 ]
+        # Note:
+        # Ideally we should only build once per OS, and run tests once per OS per ES version.
+        # Due to some limitations of Github Actions, it takes too much effort to implement and maintain.
+        # For simplicity, we use an ES matrix here, although it results in multiple builds per OS.
         es: [ "elasticsearch:7.17.8", "elasticsearch:8.5.3" ]
     runs-on: ${{ matrix.os }}
     services:

diff --git a/.github/workflows/build-and-test.ubuntu-release.yml b/.github/workflows/build-and-test.ubuntu-release.yml
@@ -9,6 +9,10 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-20.04 ]
+        # Note:
+        # Ideally we should only build once per OS, and run tests once per OS per ES version.
+        # Due to some limitations of Github Actions, it takes too much effort to implement and maintain.
+        # For simplicity, we use an ES matrix here, although it results in multiple builds per OS.
         es: [ "elasticsearch:7.17.8", "elasticsearch:8.5.3" ]
     runs-on: ${{ matrix.os }}
     services:

diff --git a/.github/workflows/sonar-scan.yml b/.github/workflows/sonar-scan.yml
@@ -9,6 +9,10 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-20.04 ]
+        # Note:
+        # Ideally we should only build once per OS, and run tests once per OS per ES version.
+        # Due to some limitations of Github Actions, it takes too much effort to implement and maintain.
+        # For simplicity, we use an ES matrix here, although it results in multiple builds per OS.
         es: [ "elasticsearch:8.5.3" ]
     runs-on: ${{ matrix.os }}
     services: