Browser discovery refactoring #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I finally got most of this working and it's a lot more reliable. Version and browser discovery is only done when requested. All errors are getting passed all the way through. Tests actually launch browsers and make sure they call back. Mac OS and Linux seem to be working fine, Windows needs some updating (but it's getting there as well). |
|
Holy. That was open for a real long time 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To start the tradition with opening a PR during implementation :)
This refactoring should improve the dynamic browser discovery and avoid unnecessary work being done. Switching from async to Promises using RSVP.js.