Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs to pass args for PhantomJS runner when running on Unix #13

Closed
alexisabril opened this issue Jul 29, 2013 · 1 comment
Closed

Needs to pass args for PhantomJS runner when running on Unix #13

alexisabril opened this issue Jul 29, 2013 · 1 comment

Comments

@alexisabril
Copy link
Contributor

Currently no arguments are passed when running via PhantomJS on a Unix platform. This only needs to match the MacOS runner as such:

unix: https://github.com/ekryski/launchpad/blob/master/lib/local/platform/unix.js#L25

vs

mac: https://github.com/ekryski/launchpad/blob/master/lib/local/platform/macos.js#L58
@daffl daffl closed this as completed in 6f864dd Jul 29, 2013
daffl added a commit that referenced this issue Jul 29, 2013
@daffl
Merge pull request #14 from alexisabril/master
7a6ec5c 
Fixes #13. Added argument list for unix platform.
@ekryski
Copy link
Contributor

ekryski commented Jul 29, 2013

👍 Nice work @alexisabril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexisabril @ekryski