Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] Allow enabling TLS without volume-permissions #9016

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Feb 15, 2022

Signed-off-by: juan131 [email protected]

Description of the change

It shouldn't be necessary to run a "root" container to adapt volume permissions to enable TLS. This PR address that.

Benefits

TLS without using a "root" container.

Possible drawbacks

None

Applicable issues

Additional information

N/A

Checklist

@juan131 juan131 force-pushed the postgresql-tls-permissions branch from 8b84dec to 1052a31 Compare February 16, 2022 07:35
@juan131 juan131 marked this pull request as ready for review February 16, 2022 07:36
Copy link
Contributor

@marcosbc marcosbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comment

@@ -26,4 +26,4 @@ name: postgresql
sources:
- https://github.com/bitnami/bitnami-docker-postgresql
- https://www.postgresql.org/
version: 11.0.4
version: 11.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is implementing a new feature, we should at least increase the minor version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a new feature but removing a blocking condition that made no sense.

@juan131 juan131 merged commit 6cb95db into bitnami:master Feb 17, 2022
@juan131 juan131 deleted the postgresql-tls-permissions branch February 17, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/postgresql] Volume permission container should not be required to use TLS
2 participants