Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate in image pull secrets #16529

Merged
merged 3 commits into from
May 12, 2023
Merged

Remove duplicate in image pull secrets #16529

merged 3 commits into from
May 12, 2023

Conversation

qtpngo
Copy link
Contributor

@qtpngo qtpngo commented May 9, 2023

Description of the change

Remove duplication in image pull secrets rendering

Benefits

  • No warning in console log
  • Make it cleaner in the rendered image pull secret in k8s manifest

Possible drawbacks

There should be no drawbacks since the name of pull secret should be unique.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the common label May 9, 2023
@github-actions github-actions bot added the triage Triage is needed label May 9, 2023
@bitnami-bot bitnami-bot requested a review from carrodher May 9, 2023 13:00
@carrodher carrodher added the verify Execute verification workflow for these changes label May 9, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels May 9, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher May 9, 2023 13:02
@bitnami-bot bitnami-bot requested a review from aoterolorenzo May 9, 2023 13:02
@qtpngo qtpngo marked this pull request as ready for review May 9, 2023 13:03
aoterolorenzo
aoterolorenzo approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@aoterolorenzo aoterolorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

LGTM

@aoterolorenzo
Copy link
Contributor

@qtpngo Could you resolve the conflicts before merging?

@qtpngo
Copy link
Contributor Author

qtpngo commented May 11, 2023

I have just resolved the conflicts.
Please have a look again.
Thanks for reviewing the PR 👍

@aoterolorenzo aoterolorenzo merged commit ddfea70 into bitnami:main May 12, 2023
@qtpngo qtpngo deleted the uniq-pull-secret branch May 12, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoterolorenzo aoterolorenzo aoterolorenzo approved these changes

Assignees

@aoterolorenzo aoterolorenzo

Labels
common solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qtpngo @aoterolorenzo @carrodher