Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema validation errors #957

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Fix schema validation errors #957

merged 3 commits into from
Sep 13, 2022

Conversation

alemorcuq
Copy link
Collaborator

@alemorcuq alemorcuq commented Sep 13, 2022 •
edited by agarcia-oss
Loading

Description of the change
Fix issues reported in #955 regarding schema validations:

  • Allow spec.template.data to be null
  • Preserve unknown fields for spec.template.metadata to maintain labels and avoid null validations such as createTimestamp

Also:

  • Use the schema in the controller.yaml files

Applicable issues

@alemorcuq alemorcuq mentioned this pull request Sep 13, 2022
Closed
@alemorcuq alemorcuq temporarily deployed to vmware-image-builder September 13, 2022 13:32 Inactive
alvneiayu
alvneiayu previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josvazg
josvazg reviewed Sep 13, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@alemorcuq alemorcuq temporarily deployed to vmware-image-builder September 13, 2022 13:58 Inactive
josvazg
josvazg approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvneiayu
alvneiayu approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alemorcuq alemorcuq merged commit 9d8fcb1 into bitnami-labs:main Sep 13, 2022
@alemorcuq alemorcuq deleted the 955-schema branch September 13, 2022 14:13
@brokenjacobs
Copy link

LGTM validation issues seem to be gone.

@sathieu sathieu mentioned this pull request Sep 14, 2022
Closed
This was referenced Sep 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@alvneiayu alvneiayu alvneiayu approved these changes

@agarcia-oss agarcia-oss Awaiting requested review from agarcia-oss agarcia-oss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alemorcuq @brokenjacobs @josvazg @alvneiayu