Disable key rotation by default #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjo
approved these changes
Jul 17, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
187: Disable key rotation by default r=mkmik a=mkmik It's premature to enable key-rotation by default. See open issues like #185. Ref #137 This should unblock the possibility of cutting a release with a lot of important features and let users who want key-rotation to opt-in and deal with the consequences. Co-authored-by: Marko Mikulicic <[email protected]>
Build succeeded |
This was referenced Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's premature to enable key-rotation by default. See open issues like #185.
Ref #137
This should unblock the possibility of cutting a release with a lot of important features
and let users who want key-rotation to opt-in and deal with the consequences.