Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commonAnnotations are not implemented for all resources #1372

Closed
lindhe opened this issue Nov 11, 2023 · 0 comments · Fixed by #1471
Closed

commonAnnotations are not implemented for all resources #1372

lindhe opened this issue Nov 11, 2023 · 0 comments · Fixed by #1471
Labels
chart enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap

Comments

@lindhe
Copy link
Contributor

lindhe commented Nov 11, 2023

The documentation for the commonAnnotations value says "Annotations to add to all deployed resources":

## @param commonAnnotations [object] Annotations to add to all deployed resources

Yet, not all resources have annotations at all, let alone the common annotations:

metadata:
name: {{ include "sealed-secrets.fullname" . }}
labels: {{- include "sealed-secrets.labels" . | nindent 4 }}
{{- if .Values.rbac.labels }}
{{- include "sealed-secrets.render" ( dict "value" .Values.rbac.labels "context" $) | nindent 4 }}
{{- end }}

I suggest we implement commonAnnotations to work as documented. Depending on the circumstances, it might be good to implement it via a template in _helpers.tpl and reference that instead.

@alvneiayu alvneiayu added enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap chart labels Nov 15, 2023
alemorcuq pushed a commit that referenced this issue Mar 4, 2024
**Description of the change**

Add common annotations to all resources in the helm chart as per the
[documentation](https://github.com/bitnami-labs/sealed-secrets/blob/main/helm/sealed-secrets/values.yaml#L19):
`## @param commonAnnotations [object] Annotations to add to all deployed
resources`

**Benefits**

Add common annotations to all resources in the helm chart as per the
documentation

**Applicable issues**

- fixes #1372

Signed-off-by: cyrgim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart enhancement help wanted Feature requests approved by maintainers that are not included in the project roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants