Apply suggestions from code review

Co-authored-by: Alejandro Moreno <[email protected]> Signed-off-by: josvaz <[email protected]>
bitnami-labs · Mar 6, 2023 · a0344ee · a0344ee
1 parent 5325e94
commit a0344ee
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/carvel/package.yaml b/carvel/package.yaml
@@ -67,7 +67,7 @@ spec:
           type: boolean
           description: Specifies whether the Sealed Secrets controller should update the status subresource
           default: true
-        skip-recreate:
+        skipRecreate:
           type: boolean
           description: Specifies whether the Sealed Secrets controller should skip recreating removed secrets
           default: false

diff --git a/helm/sealed-secrets/README.md b/helm/sealed-secrets/README.md
@@ -92,7 +92,7 @@ The command removes all the Kubernetes components associated with the chart and
 | `createController`                                | Specifies whether the Sealed Secrets controller should be created                    | `true`                              |
 | `secretName`                                      | The name of an existing TLS secret containing the key used to encrypt secrets        | `sealed-secrets-key`                |
 | `updateStatus`                                    | Specifies whether the Sealed Secrets controller should update the status subresource | `true`                              |
-| `skip-recreate`                                   | Specifies whether the Sealed Secrets controller should skip recreating removed secrets | `false`                              |
+| `skipRecreate`                                   | Specifies whether the Sealed Secrets controller should skip recreating removed secrets | `false`                              |
 | `keyrenewperiod`                                  | Specifies key renewal period. Default 30 days                                        | `""`                                |
 | `rateLimit`                                       | Number of allowed sustained request per second for verify endpoint                   | `""`                                |
 | `rateLimitBurst`                                  | Number of requests allowed to exceed the rate limit per second for verify endpoint   | `""`                                |

diff --git a/helm/sealed-secrets/templates/deployment.yaml b/helm/sealed-secrets/templates/deployment.yaml
@@ -70,7 +70,7 @@ spec:
             {{- if .Values.updateStatus }}
             - --update-status
             {{- end }}
-            {{- if .Values.recreate }}
+            {{- if .Values.skipRecreate }}
             - --skip-recreate
             {{- end }}
             {{- if .Values.keyrenewperiod }}

diff --git a/helm/sealed-secrets/values.yaml b/helm/sealed-secrets/values.yaml
@@ -61,7 +61,7 @@ updateStatus: true
 ## environments when old versions of the controller did not require watch permissions on secrets
 ## for secret re-creation.
 ##
-skip-recreate: false
+skipRecreate: false
 ## @param keyrenewperiod Specifies key renewal period. Default 30 days
 ## e.g
 ## keyrenewperiod: "720h30m"

diff --git a/pkg/controller/controller_test.go b/pkg/controller/controller_test.go
@@ -59,7 +59,7 @@ func TestDefaultConfigDoesNotSkipRecreate(t *testing.T) {
 	var tweakopts func(*metav1.ListOptions)
 	clientset := fake.NewSimpleClientset()
 	ssc := ssfake.NewSimpleClientset()
-	sinformer := initSecretInformerFactory(clientset, ns, tweakopts, false /* skip-recreate */)
+	sinformer := initSecretInformerFactory(clientset, ns, tweakopts, false)
 	if sinformer == nil {
 		t.Fatalf("sinformer %v want non nil", sinformer)
 	}
@@ -77,7 +77,7 @@ func TestSkipReleaseConfigDoesSkipIt(t *testing.T) {
 	var tweakopts func(*metav1.ListOptions)
 	clientset := fake.NewSimpleClientset()
 	ssc := ssfake.NewSimpleClientset()
-	sinformer := initSecretInformerFactory(clientset, ns, tweakopts, true /* skip-recreate */)
+	sinformer := initSecretInformerFactory(clientset, ns, tweakopts, true)
 	if sinformer != nil {
 		t.Fatalf("sinformer %v want nil", sinformer)
 	}