Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alejandro Moreno <[email protected]>
Signed-off-by: josvaz <[email protected]>
  • Loading branch information
josvaz and alemorcuq authored Mar 6, 2023
1 parent 3cebdeb commit 24788dd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion helm/sealed-secrets/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ secretName: "sealed-secrets-key"
## @param updateStatus Specifies whether the Sealed Secrets controller should update the status subresource
##
updateStatus: true
## @param skip-recreate Specifies whether the Sealed Secrets controller should skip recreating removed secrets
## @param skipRecreate Specifies whether the Sealed Secrets controller should skip recreating removed secrets
## Setting it to false allows to optionally restore backward compatibility in low priviledge
## environments when old versions of the controller did not require watch permissions on secrets
## for secret re-creation.
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func TestDefaultConfigDoesNotSkipRecreate(t *testing.T) {
}
}

func TestSkipReleaseConfigDoesSkipIt(t *testing.T) {
func TestSkipRecreateConfigDoesSkipIt(t *testing.T) {
ns := "some-namespace"
var tweakopts func(*metav1.ListOptions)
clientset := fake.NewSimpleClientset()
Expand Down

0 comments on commit 24788dd

Please sign in to comment.