Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Make Request Logging Format Configurable #423

Merged
merged 3 commits into from
Dec 4, 2017

Conversation

seiffert
Copy link
Contributor

We want to analyze access logs of the oauth2 proxy in our centralized logging system where we use a slightly different access log format.

This PR makes the request logging format configurable via a template string passed as -request-logging-format. The default format stays the same of course.

@seiffert seiffert force-pushed the configure_accesslog_format branch from 90159fd to e936a9d Compare July 14, 2017 11:55
@seiffert
Copy link
Contributor Author

seiffert commented Aug 3, 2017

Are you interested in this feature? ping @jehiah (sorry to bother you personally, I just found you in the contributor list)

@jehiah jehiah added this to the v2.3 milestone Oct 23, 2017
@talam talam force-pushed the configure_accesslog_format branch from e936a9d to 1cefc96 Compare December 4, 2017 17:53
@talam talam self-requested a review December 4, 2017 17:54
Copy link
Contributor

@talam talam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. made one small addition to your first commit. you missed the flagSet.String in main.go

@talam talam merged commit faff555 into bitly:master Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants