Fix multiple issues #6075
Merged
Fix multiple issues #6075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-kaufman
reviewed
Feb 13, 2025
src/components/HomeScreenHeader.tsx
Outdated
| @@ -105,7 +105,7 @@ const HomeScreenHeader: React.FC<HomeScreenHeaderProps> = ({ | |||
| color={`${colorMode}.choosePlanHome`} | |||
| medium | |||
| > | |||
| {capitalizeEachWord(title === wallet.more ? common.keeperSettings : title)} | |||
There was a problem hiding this comment.
This does not look good, please leave the header with the previous title and gear icon
ben-kaufman
reviewed
Feb 13, 2025
| @@ -118,6 +118,7 @@ | |||
| "manageUTXO": "manage UTXO", | |||
| "manageKeys": "Manage Keys", | |||
| "manageKeysDesc": "Securely manage your keys with ease", | |||
| "moreOption": "More Option", | |||
ben-kaufman
reviewed
Feb 13, 2025
| ].filter(Boolean); | ||
| default: | ||
| return [ | ||
| { tag: 'Multi-key', color: Colors.mintGreen }, | ||
| { tag: getSchemeTag(wallet as Vault), color: Colors.LightMossGreen }, | ||
| { tag: 'Multi-key', color: Colors.LabelLight3 }, |
There was a problem hiding this comment.
It's not enough to assign the colors like this, the colors need to be consistent, ie first pill color is the same for all then second is also same for all etc,
ben-kaufman
reviewed
Feb 13, 2025
src/screens/Home/HomeScreen.tsx
Outdated
| @@ -9,7 +9,7 @@ import ToastErrorIcon from 'src/assets/images/toast_error.svg'; | |||
|
|
|||
| import KeysIcon from 'src/assets/images/homeGreenKeyIcon.svg'; | |||
| import ConciergeIcon from 'src/assets/images/faq-green.svg'; | |||
| import SettingIcon from 'src/assets/images/settingsGreenIcon.svg'; | |||
| import SettingIcon from 'src/assets/images/more-green.svg'; | |||
There was a problem hiding this comment.
Return to the gear icon
|
ben-kaufman
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6064
#6062
#6030
#6002