-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease v-9.2.1-pre-01 (#9608) #9609
Prerelease v-9.2.1-pre-01 (#9608) #9609
Conversation
WalkthroughThis pull request involves a comprehensive version update from Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)
27-36
: Consider staged rollout for pre-release versionsGiven this is a pre-release version update affecting multiple components, consider:
- Documenting any breaking changes or new features in the pre-release
- Planning a staged rollout strategy, especially for the client-side components
- Setting up a rollback plan in case issues are discovered
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
src/Besql/Bit.Besql/wwwroot/bit-besql.js
(1 hunks)src/Bit.Build.props
(1 hunks)src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
(1 hunks)src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj
(1 hunks)src/BlazorUI/Demo/Directory.Build.props
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
(1 hunks)src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.js
(1 hunks)src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
(1 hunks)src/Bup/Bit.Bup/Scripts/bit-bup.ts
(1 hunks)src/Butil/Bit.Butil/Scripts/butil.ts
(1 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
(2 hunks)src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
(1 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props
(2 hunks)src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props
(2 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj
(1 hunks)src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
(1 hunks)src/Websites/Careers/src/Directory.Build.props
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
(1 hunks)src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj
(1 hunks)src/Websites/Platform/src/Directory.Build.props
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj
(1 hunks)src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
(1 hunks)src/Websites/Sales/src/Directory.Build.props
(1 hunks)
✅ Files skipped from review due to trivial changes (26)
- src/Websites/Careers/src/Directory.Build.props
- src/Besql/Bit.Besql/wwwroot/bit-besql.js
- src/Websites/Platform/src/Directory.Build.props
- src/Bswup/FullDemo/Client/wwwroot/service-worker.js
- src/Websites/Sales/src/Directory.Build.props
- src/BlazorUI/Demo/Directory.Build.props
- src/Butil/Bit.Butil/Scripts/butil.ts
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
- src/Bup/Bit.Bup/Scripts/bit-bup.ts
- src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
- src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
- src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
- src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
- src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
- src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
- src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
- src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
- src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
- src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
- src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
- src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
🔇 Additional comments (21)
src/Bit.Build.props (1)
30-30
: Version bump looks consistent.
This change from9.2.0
to9.2.1-pre-01
matches the overall versioning strategy. No issues spotted.src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)
41-41
: Updated version ensures alignment with the pre-release cycle.
No functional issues observed; the command update fromBit.Boilerplate::9.2.0
to9.2.1-pre-01
is straightforward and consistent.src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (2)
4-11
: Coordinated version updates for multiple packages.
All updated references appear consistent with the new version9.2.1-pre-01
. No issues identified.
49-49
: Offline DB condition version update
MovingBit.Besql
to9.2.1-pre-01
aligns with the rest of the file’s changes. Looks good.src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2)
4-11
: Consistent version increment.
All listed packages now target9.2.1-pre-01
, ensuring uniform pre-release updates.
52-52
: Includes offline DB scenario in version alignment.
UpdatingBit.Besql
to9.2.1-pre-01
under theofflineDb
condition mirrors changes throughout the file. Approved.src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)
177-178
: Version reference updated successfully.The updated installation command for the Bit Boilerplate template now references the
9.2.1-pre-01
version. This correctly aligns with the broader version increments across the solution. Ensure that this pre-release version is widely available and that the installation command works as expected in all environments.src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1)
9-13
: Synchronize package versions across the solution.Upgrading
Bit.CodeAnalyzers
andBit.SourceGenerators
to9.2.1-pre-01
looks consistent with the overall version increments in the PR. Make sure that all dependent projects referencing these packages are also updated, and confirm that the pre-release versions contain the features or fixes needed.src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1)
9-13
: Keep an eye on future updates.These changes align well with the updates in other project files for
Bit.CodeAnalyzers
andBit.SourceGenerators
. Since these are pre-release versions, be prepared for possible additional updates if new prerelease patches are released.src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)
13-17
: Consistent versioning applied.The version bumps for
Bit.CodeAnalyzers
andBit.SourceGenerators
keep this project aligned with the rest of the solution. Verify downstream dependencies (e.g., build pipelines, code generation tasks) for potential version compatibility issues.src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)
13-20
: Verify pre-release version compatibilityThe update to pre-release versions (
9.2.1-pre-01
) ofBit.CodeAnalyzers
andBit.SourceGenerators
is consistent with the PR objectives. Since these are development-time dependencies, there's minimal risk to runtime behavior.Let's verify the availability and stability of these pre-release packages:
✅ Verification successful
The previous attempt to verify package availability through NuGet API failed. Let's analyze the local usage pattern of these packages across the codebase to understand if this version is consistently used and potentially part of an internal pre-release strategy.
Pre-release package version is consistently used across the solution
The version
9.2.1-pre-01
of bothBit.CodeAnalyzers
andBit.SourceGenerators
is consistently used across multiple projects in the solution, including:
- Website projects (Sales, Careers, Platform)
- BlazorUI Demo projects
- Template projects
While the packages are not found in the public NuGet feed, their consistent usage across the codebase suggests they are likely available through an internal package source. Since these are development-time dependencies (all using
PrivateAssets>all
), the pre-release version is acceptable as it won't affect runtime behavior.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify package availability and check for any reported issues # Note: These are development dependencies, so we're mainly checking availability # Check if packages are available on NuGet curl -s "https://api.nuget.org/v3/registration5-semver1/bit.codeanalyzers/index.json" | jq '.items[].items[].catalogEntry | select(.version=="9.2.1-pre-01")' curl -s "https://api.nuget.org/v3/registration5-semver1/bit.sourcegenerators/index.json" | jq '.items[].items[].catalogEntry | select(.version=="9.2.1-pre-01")'Length of output: 434
Script:
#!/bin/bash # Let's check if there are any other projects using these packages and their versions fd -e csproj -x grep -l "Bit.CodeAnalyzers\|Bit.SourceGenerators" {} # For each found file, let's see the package versions fd -e csproj -x cat {} | grep -A 3 "PackageReference.*Bit\.\(CodeAnalyzers\|SourceGenerators\)"Length of output: 10589
src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1)
13-20
: Changes mirror those in Careers.Server projectThe version updates are identical to those in the Careers.Server project, maintaining consistency across the codebase.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)
27-36
: Additional runtime package update requires attentionWhile the updates to
Bit.CodeAnalyzers
andBit.SourceGenerators
mirror previous changes, the update toBit.Bswup
requires additional consideration as it's not marked as a development-time dependency and could affect runtime behavior.Let's verify the impact of the Bit.Bswup update:
✅ Verification successful
Bit.Bswup update is safe to proceed
Based on the codebase analysis, the Bit.Bswup package is used consistently across the application for PWA functionality and update progress tracking. The usage patterns show:
- Standard integration through script includes (
bit-bswup.js
andbit-bswup.progress.js
)- Consistent usage of
BswupProgress
component with standard parameters- No custom implementations that could be affected by the version update
The update from an earlier version to 9.2.1-pre-01 appears safe as the core functionality and component usage remain unchanged in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for breaking changes in Bit.Bswup and its usage # Check for any breaking changes in release notes curl -s "https://api.nuget.org/v3/registration5-semver1/bit.bswup/index.json" | jq '.items[].items[].catalogEntry | select(.version=="9.2.1-pre-01")' # Look for Bit.Bswup usage patterns that might be affected rg -l "Bit.Bswup" | while read -r file; do if [[ $file == *.cs || $file == *.razor ]]; then echo "=== $file ===" rg "Bswup" "$file" fi doneLength of output: 19898
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)
32-38
: Package version updates look good!The version updates for
Bit.CodeAnalyzers
andBit.SourceGenerators
to9.2.1-pre-01
are consistent with the pre-release version bump. The package configurations (PrivateAssets and IncludeAssets) are maintained correctly.src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (2)
25-35
: Package version updates are consistentThe version updates for all Bit.* packages to
9.2.1-pre-01
are consistent with the pre-release version bump:
- Bit.BlazorUI
- Bit.BlazorUI.Icons
- Bit.BlazorUI.Assets
- Bit.CodeAnalyzers
- Bit.SourceGenerators
Line range hint
18-22
: Verify configuration file accessibility after type changesThe change of
appsettings.json
from Content to EmbeddedResource affects how the configuration is loaded at runtime. Please ensure that:
- The application correctly loads the embedded configuration
- The configuration values are accessible during runtime
✅ Verification successful
Configuration loading is properly implemented for embedded appsettings.json
The search results confirm that the project correctly handles embedded configuration files. Specifically, in
src/Websites/Sales/src/Bit.Websites.Sales.Client/Extensions/IConfigurationBuilderExtensions.cs
, there is proper implementation for loading the embedded appsettings.json:builder.AddJsonStream(assembly.GetManifestResourceStream("Bit.Websites.Sales.Client.appsettings.json")!);This implementation follows the same pattern used across other projects in the codebase, including the boilerplate templates and other website projects. The change from Content to EmbeddedResource is safe as the configuration loading code is already set up to handle embedded resources.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for configuration loading code rg -A 5 "GetManifestResourceStream.*appsettings.json" # Check for any existing embedded resource loading patterns rg -A 5 "Assembly.GetManifestResourceStream"Length of output: 11554
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1)
Line range hint
18-35
: Changes are consistent with other client projectsThe modifications in this project mirror those in
Bit.Websites.Sales.Client.csproj
:
- Configuration file handling
- Package version updates to
9.2.1-pre-01
- Build configuration changes
This consistency across projects is good for maintainability.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)
19-26
: LGTM! Package versions updated consistently.The version updates for
Bit.CodeAnalyzers
andBit.SourceGenerators
to9.2.1-pre-01
are consistent with the pre-release version bump.src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1)
25-37
: LGTM! Package versions updated consistently.All Bit.* package references have been updated to version
9.2.1-pre-01
, maintaining consistency across the ecosystem:
- Bit.Butil
- Bit.BlazorUI
- Bit.BlazorUI.Icons
- Bit.BlazorUI.Assets
- Bit.CodeAnalyzers
- Bit.SourceGenerators
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (2)
88-96
: LGTM! Package versions updated consistently.The version updates for
Bit.CodeAnalyzers
andBit.SourceGenerators
to9.2.1-pre-01
are consistent with the pre-release version bump.
Line range hint
97-97
: LGTM! Removal of launchSettings.json is appropriate.The removal of
Properties\launchSettings.json
is appropriate for MAUI projects as they handle launch settings differently from standard web projects.
closes #9608
Summary by CodeRabbit
Release Notes for Version 9.2.1-pre-01
Version Update
Package References
Templates
Service Workers
Development