-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does HWI 0.5.0 have a fixed once_cell dependency version 1.14? #72
Comments
Hey there, thanks for reporting this! It seems like we don't even need once_cell (we probably dropped the dependency time ago, but then forgot to remove it from the |
Oh, now I just remembered: I pinned |
Makes sense! Does pinning once_cell to 1.15 still meet the MSRV requirements you have?
…-------- Original Message --------
On Feb 19, 2023, 6:13 PM, Daniela Brozzoni wrote:
Oh, now I just remembered: I pinned once_cell to 0.14.0 to keep the MSRV low enough (0.17.0 requires rust 1.56!)
—
Reply to this email directly, [view it on GitHub](#72 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABCS7WXAAZRMUZ4C3BEWB7LWYJPFVANCNFSM6AAAAAAVALVBBI).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No, as we try to target rust 1.48, but once_cell 1.15 requires rust 1.56. I'm now thinking about publishing a whole new major version of hwi with the latest dependencies, so that hwi 2.* has the latest dependencies, while hwi 1.* keeps a low MSRV |
Ok, makes sense. I'll be looking forward to that one then! Thanks for all the work you do. |
Steve found a workaround! 🎉
If it works properly I'll release hwi 0.6.0 :) |
Thanks @danielabrozzoni! I added the line
Here is my
|
Ah, I forgot you were using bdk! Basically rust is still importing hwi 0.5.0 as a dependency of bdk, and so you have the same error. The solution would be to tell rust to use bdk with hwi master as a dependency, but I honestly don't remember how to do that (maybe it can be done using patch-crates.io ?) I don't have much time right now, but I'll try to find a way to do so in the next few days, sorry! This could help: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html |
Thank you! And no worries, you've already helped me quite a bunch. I'll try to figure it out. |
Try adding a [dependencies]
tauri = "^1.2"
bdk = { version = "0.27.0", features = ["hardware-signer"] }
[patch.crates-io]
hwi = { git = "https://github.com/bitcoindevkit/rust-hwi" } |
It worked this time! ✅ Thank you. |
I hope this is the right place to get some help on this. I spoke with the Tauri team but they couldn't help.
I am building a desktop app with Rust using Tauri and BDK. I tried to update to the latest version of BDK
0.27.0
but I get an error due to conflicting versions in the HWI Rust wrapper dependencies. The error message is below.It looks like
BDK 0.27.0
requiresHWI 0.5.0
from crates.io, which requires exactly theonce_cell 1.14.0
crate. This version requirement in HWI conflicts with what Tauri currently requires on its LTS version (1.2
), which is at leastonce_cell 1.15.0
.Why does
HWI 0.5.0
require exactly version=1.14
for once_cell? Why not^1.14
instead? Would you have a way to fix this?Thank you!
The text was updated successfully, but these errors were encountered: