Skip to content

Merge bitcoindevkit/rust-esplora-client#96: fix(ci): code coverage `a… #455

Merge bitcoindevkit/rust-esplora-client#96: fix(ci): code coverage `a…

Merge bitcoindevkit/rust-esplora-client#96: fix(ci): code coverage `a… #455

Triggered via push September 7, 2024 04:56
Status Failure
Total duration 7m 41s
Artifacts
Rust Formatting
13s
Rust Formatting
Rust Clippy
2m 1s
Rust Clippy
Matrix: Build & Test
Fit to window
Zoom out
Zoom in

Annotations

31 errors and 24 warnings
the borrowed expression implements the required traits: src/async.rs#L412
error: the borrowed expression implements the required traits --> src/async.rs:412:18 | 412 | .get(&format!("{}/fee-estimates", self.url,)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/fee-estimates", self.url,)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L359
error: the borrowed expression implements the required traits --> src/async.rs:359:18 | 359 | .get(&format!("{}/block-height/{}", self.url, block_height)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block-height/{}", self.url, block_height)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L341
error: the borrowed expression implements the required traits --> src/async.rs:341:18 | 341 | .get(&format!("{}/blocks/tip/hash", self.url)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/blocks/tip/hash", self.url)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L323
error: the borrowed expression implements the required traits --> src/async.rs:323:18 | 323 | .get(&format!("{}/blocks/tip/height", self.url)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/blocks/tip/height", self.url)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L304
error: the borrowed expression implements the required traits --> src/async.rs:304:19 | 304 | .post(&format!("{}/tx", self.url)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx", self.url)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L282
error: the borrowed expression implements the required traits --> src/async.rs:282:18 | 282 | .get(&format!("{}/tx/{}/outspend/{}", self.url, txid, index)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/outspend/{}", self.url, txid, index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L254
error: the borrowed expression implements the required traits --> src/async.rs:254:18 | 254 | .get(&format!("{}/tx/{}/merkleblock-proof", self.url, tx_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/merkleblock-proof", self.url, tx_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L231
error: the borrowed expression implements the required traits --> src/async.rs:231:18 | 231 | .get(&format!("{}/tx/{}/merkle-proof", self.url, tx_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/merkle-proof", self.url, tx_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L208
error: the borrowed expression implements the required traits --> src/async.rs:208:18 | 208 | .get(&format!("{}/block/{}/raw", self.url, block_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/raw", self.url, block_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L190
error: the borrowed expression implements the required traits --> src/async.rs:190:18 | 190 | .get(&format!("{}/block/{}/status", self.url, block_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/status", self.url, block_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L171
error: the borrowed expression implements the required traits --> src/async.rs:171:18 | 171 | .get(&format!("{}/block/{}/header", self.url, block_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/header", self.url, block_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L151
error: the borrowed expression implements the required traits --> src/async.rs:151:18 | 151 | .get(&format!("{}/tx/{}", self.url, txid)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}", self.url, txid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L134
error: the borrowed expression implements the required traits --> src/async.rs:134:18 | 134 | .get(&format!("{}/tx/{}/status", self.url, txid)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/status", self.url, txid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L112
error: the borrowed expression implements the required traits --> src/async.rs:112:18 | 112 | .get(&format!("{}/block/{}/txid/{}", self.url, block_hash, index)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/txid/{}", self.url, block_hash, index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L76
error: the borrowed expression implements the required traits --> src/async.rs:76:18 | 76 | .get(&format!("{}/tx/{}/raw", self.url, txid)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/raw", self.url, txid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
the borrowed expression implements the required traits: src/async.rs#L412
error: the borrowed expression implements the required traits --> src/async.rs:412:18 | 412 | .get(&format!("{}/fee-estimates", self.url,)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/fee-estimates", self.url,)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L359
error: the borrowed expression implements the required traits --> src/async.rs:359:18 | 359 | .get(&format!("{}/block-height/{}", self.url, block_height)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block-height/{}", self.url, block_height)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L341
error: the borrowed expression implements the required traits --> src/async.rs:341:18 | 341 | .get(&format!("{}/blocks/tip/hash", self.url)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/blocks/tip/hash", self.url)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L323
error: the borrowed expression implements the required traits --> src/async.rs:323:18 | 323 | .get(&format!("{}/blocks/tip/height", self.url)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/blocks/tip/height", self.url)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L304
error: the borrowed expression implements the required traits --> src/async.rs:304:19 | 304 | .post(&format!("{}/tx", self.url)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx", self.url)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L282
error: the borrowed expression implements the required traits --> src/async.rs:282:18 | 282 | .get(&format!("{}/tx/{}/outspend/{}", self.url, txid, index)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/outspend/{}", self.url, txid, index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L254
error: the borrowed expression implements the required traits --> src/async.rs:254:18 | 254 | .get(&format!("{}/tx/{}/merkleblock-proof", self.url, tx_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/merkleblock-proof", self.url, tx_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L231
error: the borrowed expression implements the required traits --> src/async.rs:231:18 | 231 | .get(&format!("{}/tx/{}/merkle-proof", self.url, tx_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/merkle-proof", self.url, tx_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L208
error: the borrowed expression implements the required traits --> src/async.rs:208:18 | 208 | .get(&format!("{}/block/{}/raw", self.url, block_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/raw", self.url, block_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L190
error: the borrowed expression implements the required traits --> src/async.rs:190:18 | 190 | .get(&format!("{}/block/{}/status", self.url, block_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/status", self.url, block_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L171
error: the borrowed expression implements the required traits --> src/async.rs:171:18 | 171 | .get(&format!("{}/block/{}/header", self.url, block_hash)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/header", self.url, block_hash)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L151
error: the borrowed expression implements the required traits --> src/async.rs:151:18 | 151 | .get(&format!("{}/tx/{}", self.url, txid)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}", self.url, txid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L134
error: the borrowed expression implements the required traits --> src/async.rs:134:18 | 134 | .get(&format!("{}/tx/{}/status", self.url, txid)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/status", self.url, txid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L112
error: the borrowed expression implements the required traits --> src/async.rs:112:18 | 112 | .get(&format!("{}/block/{}/txid/{}", self.url, block_hash, index)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/block/{}/txid/{}", self.url, block_hash, index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/async.rs#L76
error: the borrowed expression implements the required traits --> src/async.rs:76:18 | 76 | .get(&format!("{}/tx/{}/raw", self.url, txid)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}/tx/{}/raw", self.url, txid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
Rust Clippy
Clippy had exited with the 101 exit code
Build & Test (1.63.0, blocking)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, blocking-https-rustls)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, blocking-https-rustls)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, blocking-https-native)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, blocking)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, blocking-https)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, async-https)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, async-https-native)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, async)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, async-https-rustls-manual-roots)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, async-https-rustls)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, blocking-https-bundled)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, default)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rust Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust Clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (stable, blocking-https-bundled)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, blocking-https-native)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, blocking-https)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, async)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, async-https-native)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, async-https)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, async-https-rustls)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, default)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build & Test (1.63.0, async-https-rustls-manual-roots)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/