Implement EsploraExt for async client #885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniela Brozzoni <[email protected]>
We prepare the BDK repo for a major restructuring. - database modules removed - blockchain module removed - minimal API changes. - Many macros removed. - no longer applicable examples removed. - Much conditional compilation removed. Can compile with --all-features. - delete verify module
To stop my rust-anlayzer from killing me
To allow you to re-use change addresses from transactions that get cancelled.
instead of bdk's one
we shouldn't have a feature flag for this it should always be done.
If you want to have tests on the hardware-signer you need to install the python libraries and start the emulator
Also flesh out README a bit
Original repository: https://github.com/LLFourn/bdk_core_staging/tree/250b4f1dcce10805adfb2f201901675eb6076554/bdk_chain Co-authored-by: Steve Myers <[email protected]> Co-authored-by: 志宇 <[email protected]> Co-authored-by: LLFourn <[email protected]> Co-authored-by: rajarshimaitra <[email protected]> Co-authored-by: LagginTimes <[email protected]> Co-authored-by: Steve Myers <[email protected]> Co-authored-by: Vladimir Fomene <[email protected]>
Original repository: https://github.com/LLFourn/bdk_core_staging/tree/250b4f1dcce10805adfb2f201901675eb6076554/bdk_file_store Co-authored-by: 志宇 <[email protected]> Co-authored-by: LLFourn <[email protected]> Co-authored-by: Vladimir Fomene <[email protected]>
Original repository: https://github.com/LLFourn/bdk_core_staging/tree/250b4f1dcce10805adfb2f201901675eb6076554/bdk_electrum Co-authored-by: 志宇 <[email protected]> Co-authored-by: LLFourn <[email protected]>
This completes the move of things from https://github.com/LLFourn/bdk_core_staging
I suspect the latest version of HWI just broke everything
Disabled warnings for nursery/tmp_plan as it's going to be replaced anyways
Explicitly sets the project MSRV so that clippy won't give warnings for feature added after our MSRV
- rewrite some parts of the code to deal with older borrow checker - downgraded hashbrown
There's a huge todo!() for the AsyncClient
To be enabled again soon ™️
vladimirfomene
force-pushed
the
add-async-syncing-esplora
branch
3 times, most recently
from
e9d4700 to
84940d5
Compare
Creates a separate async EsploraAsyncExt trait for the async client using async-trait crate. It has thesame methods as the EsploraExt trait for the blocking client. This trait is implemented on the AsyncClient of the rust-esplora-client crate.
vladimirfomene
force-pushed
the
add-async-syncing-esplora
branch
from
84940d5 to
48c188d
Compare
evanlinjin
reviewed
Mar 8, 2023
|
This was merged into danielabrozzoni#3 which got merged into #793 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves issue #880. It is implementing the EsploraExt trait on the Esplora Async client by defining an async version of that trait and implementing it on the async esplora client.
Notes to the reviewers
I went with the copy pasting approach. I believe it is okay since we are just doing here.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: