Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin tokio version to ~1.14 #550

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Feb 17, 2022

Description

The tokio project recently changed their MSRV to 1.49.0. This PR will pin the tokio dependency version to ~1.14 which is prior to their MSRV increase.

Notes to the reviewers

The LDK team took this approach for their tokio dev-dependency, see lightningdevkit/rust-lightning#1315.

As long as tokio backports bug fixes to1.14.x releases this should be safe. If we need any new features we can revisit this decision.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've updated CHANGELOG.md

@notmandatory
Copy link
Member Author

I think we can use this as a short term fix while we discuss #331 to determine what our MSRV should be.

@notmandatory notmandatory marked this pull request as ready for review February 17, 2022 19:52
@LLFourn
Copy link
Contributor

LLFourn commented Feb 18, 2022

ACK b04bb59

I agree this is the right thing to do for now.

@notmandatory notmandatory merged commit 5c5bb78 into bitcoindevkit:master Feb 18, 2022
@notmandatory notmandatory deleted the pin_tokio_114 branch February 18, 2022 17:45
@notmandatory notmandatory mentioned this pull request Feb 19, 2022
9 tasks
@notmandatory notmandatory self-assigned this Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants