Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin cmake to fix CI error #1829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LagginTimes
Copy link
Contributor

@LagginTimes LagginTimes commented Feb 10, 2025

Description

cmake 0.1.54 now requires cc = ^1.1.0, which caused a CI failure due to the existing cc = 1.0.105 pin.
Version 0.1.53 was pinned for CI to continue working.

Changelog notice

  • Pinned cmake dependency version.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@LagginTimes LagginTimes self-assigned this Feb 10, 2025
@LagginTimes LagginTimes added the ci label Feb 10, 2025
@LagginTimes LagginTimes changed the title ci: pin cmake for msrv ci: pin cmake to fix CI error Feb 10, 2025
@ValuedMammal
Copy link
Contributor

I wonder if we could instead just not pin cc?

@LagginTimes
Copy link
Contributor Author

cc = ^1.0.106 would require a MSRV above 1.63 (reference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants