Allow BdkElectrumClient to take client by reference
#1825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `BdkElectrumClient` has to take ownership of the internal electrum client. This is an alternative of bitcoindevkit#1820. bitcoindevkit#1820 removes the ability to have `BdkElectrumClient` take ownership.
4 tasks
tnull
reviewed
Feb 6, 2025
| @@ -6,7 +6,9 @@ use bdk_core::{ | |||
| }; | |||
| use electrum_client::{ElectrumApi, Error, HeaderNotification}; | |||
| use std::{ | |||
| borrow::Borrow, | |||
There was a problem hiding this comment.
Could you clarify why Borrow would be preferable to Deref in this case, especially since it requires a bunch of additional boilerplate, etc?
There was a problem hiding this comment.
Because Borrow has a blanket implementation so that any T impls Borrow<T>.
We still want to keep the ability to take a client by ownership imo.
|
Closing, as bitcoindevkit/rust-electrum-client#163 is a superior solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
BdkElectrumClienthas to take ownership of the internal electrum client.This is an alternative of #1820. #1820 removes the ability to have
BdkElectrumClienttake ownership.Notes to the reviewers
Is the
Cgeneric necessary? It's there just in case a caller would like to use something other thanelectrum_client::Client. Is anyone using theRawClients directly?If all we want to for
BdkElectrumClientto take in&electrum_client::Clientwe can just do the following in theelectrum_clientcrate.Changelog notice
BdkElectrumClientto take in the internal client as reference or smart pointer.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: