Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(esplora): bump esplora-client to 0.11.0 #1746

Merged

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Nov 25, 2024

Update bdk_esplora to depend on esplora-client 0.11.0

Notes to the reviewers

bitcoindevkit/rust-esplora-client#103 added a generic type parameter to AsyncClient representing a user-defined Sleeper and that change is reflected here in order to call the underlying API methods. We also add a new build feature "tokio" that enables the corresponding feature in rust-esplora-client.

closes #1742

Changelog notice

bdk_esplora: Bump esplora-client to 0.11.0

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • This pull request breaks the existing API
  • I'm linking the issue being fixed by this PR

@ValuedMammal ValuedMammal added this to the 1.0.0-beta milestone Nov 25, 2024
@LagginTimes LagginTimes added the dependencies Pull requests that update a dependency file label Nov 29, 2024
@ValuedMammal ValuedMammal marked this pull request as ready for review December 1, 2024 20:56
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2296945

I think we probably should update the bdk_esplora README.md too, here.

@ValuedMammal
Copy link
Contributor Author

❓ I think this bdk_chain/std should no longer be here right?

[features]
default = ["std", "async-https", "blocking-https"]
std = ["bdk_chain/std", "miniscript?/std"]

@ValuedMammal ValuedMammal force-pushed the deps/bump-esplora-client-0.11 branch from 165e503 to 90fd1a2 Compare December 4, 2024 19:27
@notmandatory
Copy link
Member

notmandatory commented Dec 4, 2024

❓ I think this bdk_chain/std should no longer be here right?

You're right, bdk_chain/std is already included in bdk_chain/default. But how about making a new PR to change/fix that since this one is otherwise ready to go.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 90fd1a2

I manually tested the three esplora examples and they are all working fine.

@@ -16,19 +16,21 @@ workspace = true

[dependencies]
bdk_core = { path = "../core", version = "0.3.0", default-features = false }
esplora-client = { version = "0.10.0", default-features = false }
esplora-client = { version = "0.11.0", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there's a trailing whitespace here

Suggested change
esplora-client = { version = "0.11.0", default-features = false }
esplora-client = { version = "0.11.0", default-features = false }

crates/esplora/src/async_ext.rs Show resolved Hide resolved
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 90fd1a2

@notmandatory notmandatory merged commit 2a1787b into bitcoindevkit:master Dec 6, 2024
21 checks passed
@ValuedMammal ValuedMammal deleted the deps/bump-esplora-client-0.11 branch December 10, 2024 01:16
@notmandatory notmandatory mentioned this pull request Dec 11, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bump electrum-client and esplora-client versions
4 participants