Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic to LocalChain-based types #1488

Conversation

evanlinjin
Copy link
Member

Description

This is so that we can do future upgrades to LocalChain (and associated types) in a backwards-compatible way.

@LLFourn mentioned that bdk_chain changesets can be non-changing. A LocalChain with monotone changesets can be a different type completely (for example).

However, adding "metadata" to localchain is important for merkle proofs (for electrum, cbf, etc) as we need to store the header somewhere - and it makes sense for it to be in LocalChain.

Notes to the reviewers

I will add more info later

Changelog notice

  • Added a generic B to LocalChain types.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

This is so that we can do future upgrades to `LocalChain` (and
associated types) in a backwards-compatible way.
@evanlinjin evanlinjin added the new feature New feature or request label Jun 25, 2024
@evanlinjin evanlinjin added this to the 1.0.0-alpha milestone Jun 25, 2024
@evanlinjin evanlinjin self-assigned this Jun 25, 2024
@evanlinjin evanlinjin changed the title feat(chain): add generic to localchain-based types Add generic to LocalChain-based types Jun 25, 2024
@evanlinjin
Copy link
Member Author

I just realized that since local_chain::ChangeSet<BlockId> is the same as local_chain::ChangeSet, we actually do not need this PR. We can do this change later and still be backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant