Add generic to LocalChain
-based types
#1488
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is so that we can do future upgrades to
LocalChain
(and associated types) in a backwards-compatible way.@LLFourn mentioned that
bdk_chain
changesets can be non-changing. ALocalChain
with monotone changesets can be a different type completely (for example).However, adding "metadata" to localchain is important for merkle proofs (for electrum, cbf, etc) as we need to store the header somewhere - and it makes sense for it to be in
LocalChain
.Notes to the reviewers
I will add more info later
Changelog notice
B
toLocalChain
types.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing