Rename methods of esplora ext #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirfomene
force-pushed
the
rename-methods-of-EsploraExt
branch
from
32886a4 to
91c587e
Compare
30 tasks
41 tasks
realeinherjar
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
ACK 2090021
The renaming seems OK.
I've run all wallet_* examples and it works fine.
I had to change blocktream.info -> mempool.space due to 429 HTTP errors.
vladimirfomene
force-pushed
the
rename-methods-of-EsploraExt
branch
2 times, most recently
from
b60a1d9 to
98c8e0e
Compare
vladimirfomene
force-pushed
the
rename-methods-of-EsploraExt
branch
from
98c8e0e to
2090021
Compare
danielabrozzoni
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
ACK 2090021 - code looks good, example_esplora and wallet_esplora_blocking work just fine.
The wallet esplora async example give back a 429 error with blockstream.info as @realeinherjar reported, but it's happening on master as well. I opened #1120 to track the issue.
40 tasks
3 tasks
notmandatory
added a commit
that referenced
this pull request
Jan 6, 2024
…c and full_scan functions de54e71 refactor(esplora_ext): rename scan_txs to sync and scan_txs_with_keychains to full_scan (Steve Myers) 95d3485 refactor(electrum_ext): rename scan_without_keychain to sync and scan to full_scan (Steve Myers) Pull request description: ### Description fixes #1112 Simple function renaming plus updated docs: 1. electrum_ext: rename functions `scan_without_keychain` to `sync` and `scan` to `full_scan` 2. esplora_ext: rename functions `scan_txs` to `sync` and `scan_txs_with_keychains` to `full_scan` ### Notes to the reviewers The esplora_ext changes were partially fixed in #1070 but I renamed again so the functions match names ~~suggested in #1112~~ agreed on in discord poll, `sync` and `full_scan`. ### Changelog notice Changed - electrum_ext: rename functions scan_without_keychain to sync and scan to full_scan - esplora_ext: rename functions scan_txs to sync and scan_txs_with_keychains to full_scan ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing Top commit has no ACKs. Tree-SHA512: d34516ecc513a194b679f73a1260d0cbc3d12b6a2e162d822e7381da0b3250aff319e85ed2fadec506e36f95a78a5cd79d0ab972da2b02928c074be17664da08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1058. Built on top of #1040
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: