-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Anchor for BlockId #1069
Implement Anchor for BlockId #1069
Conversation
6328bd1
to
442870f
Compare
Is it possible to demonstrate using this in a test or example? |
@notmandatory let me look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just some thoughts.
442870f
to
9b5a496
Compare
I think I will be using this for the Nakamoto syncing logic, @evanlinjin do you have an idea on how to write an example or test for this? |
I think a documentation test for Like using a |
And did |
542e51b
to
6f7f3a6
Compare
a846271
to
b8a5a96
Compare
Will rebase once #1077 gets merged |
b8a5a96
to
691bdf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits :)
d81278c
to
101e6dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, we are nearly there. Documentation can be better.
101e6dd
to
f39323e
Compare
f39323e
to
96d38b9
Compare
96d38b9
to
18e8da3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 18e8da3
Description
This PR fixes #1062.
It implements the
Anchor
trait onBlockId
.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features: