Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taproot descriptor template, BIP-0086 #836

Open
danielnordh opened this issue Jan 17, 2023 · 2 comments
Open

Add taproot descriptor template, BIP-0086 #836

danielnordh opened this issue Jan 17, 2023 · 2 comments
Assignees
@vladimirfomene
Labels
new feature New feature or request

Comments

@danielnordh
Copy link

The new descriptor templates in 0.26 are great, but we are missing taproot.
Please add functions similar to the ones already included for native segwit:

public static func `newBip84`(`secretKey`: DescriptorSecretKey, `keychain`: KeychainKind, `network`: Network)  -> Descriptor
public static func `newBip84Public`(`publicKey`: DescriptorPublicKey, `fingerprint`: String, `keychain`: KeychainKind, `network`: Network)  -> Descriptor
@notmandatory notmandatory transferred this issue from bitcoindevkit/bdk-ffi Jan 17, 2023
@notmandatory notmandatory moved this to Todo in BDK-Bindings Jan 17, 2023
@notmandatory notmandatory added the new feature New feature or request label Jan 17, 2023
@notmandatory
Copy link
Member

The template spec is BIP-0086: https://github.com/bitcoin/bips/blob/master/bip-0086.mediawiki

@vladimirfomene
Copy link
Contributor

@notmandatory, can I take this up?

vladimirfomene pushed a commit to vladimirfomene/bdk that referenced this issue Jan 20, 2023
create taproot descriptor template
9f940fd 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.

Signed-off-by: vladimirfomene <[email protected]>
vladimirfomene pushed a commit to vladimirfomene/bdk that referenced this issue Jan 23, 2023
create taproot descriptor template
242f5bd 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.

Signed-off-by: vladimirfomene <[email protected]>
@vladimirfomene vladimirfomene mentioned this issue Jan 23, 2023
Merged
8 tasks
vladimirfomene added a commit to vladimirfomene/bdk that referenced this issue Feb 14, 2023
@vladimirfomene
Create taproot descriptor template
fb8d20d 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.
vladimirfomene added a commit to vladimirfomene/bdk that referenced this issue Feb 15, 2023
@vladimirfomene
Create taproot descriptor template
6470776 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.
@notmandatory notmandatory changed the title Add taproot descriptor template Add taproot descriptor template, BIP-0086 Mar 2, 2023
@notmandatory notmandatory mentioned this issue Mar 2, 2023
Closed
@notmandatory notmandatory moved this to Needs Review in BDK Wallet May 24, 2023
vladimirfomene added a commit to vladimirfomene/bdk that referenced this issue May 25, 2023
@vladimirfomene
Create taproot descriptor template
50ac75e 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.
vladimirfomene added a commit to vladimirfomene/bdk that referenced this issue May 25, 2023
@vladimirfomene
Create taproot descriptor template
e30919b 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.
notmandatory added a commit that referenced this issue Jun 19, 2023
@notmandatory
Merge #840: create taproot descriptor template
b184e35 
e30919b Create taproot descriptor template (Vladimir Fomene)

Pull request description:

  ### Description

  This PR solves #836. This PR adds a P2TR
  descriptor template and a BIP86 taproot
  descriptor template. With this, users
  can now create a taproot descriptor with templates.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK e30919b

Tree-SHA512: ad171d29e1b22613a9fb5e6ed148d1d3002c76152df1b5aa94e24be134d08d7c90dda9560b7501a8df28e5a7076339745da627bbdde5ed6fa11eab3199c34a99
@notmandatory notmandatory mentioned this issue Jun 20, 2023
Closed
@notmandatory notmandatory moved this from Needs Review to Done in BDK Wallet Jul 19, 2023
notmandatory pushed a commit to notmandatory/bdk that referenced this issue Jul 19, 2023
@vladimirfomene @notmandatory
Create taproot descriptor template
177c96d 
This PR solves bitcoindevkit#836. This PR adds a P2TR
descriptor template and a BIP86 taproot
descriptor template. With this, users
can now create a taproot descriptor with templates.
@notmandatory notmandatory mentioned this issue Jul 19, 2023
Merged
5 tasks
notmandatory added a commit that referenced this issue Aug 2, 2023
@notmandatory
Merge #1033: Backport new taproot descriptor template (BIP86)
d0f7543 
7587f16 feat(descriptor): backport from master branch new taproot descriptor template (BIP86) (Steve Myers)
177c96d Create taproot descriptor template (Vladimir Fomene)

Pull request description:

  ### Description

  This PR solves #836 for the release/0.28 branch. This PR adds a P2TR descriptor template and a BIP86 taproot descriptor template. With this, users can now create a taproot descriptor with templates.

  ### Notes to the reviewers

  The commit from #840 is cherry-picked from the `master` branch to the `release/0.28` branch without any changes.

  ### Changelog notice

  Add taproot descriptor template (BIP-86).

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  danielabrozzoni:
    utACK 7587f16

Tree-SHA512: e5b07473e27bba8ca5ec58854fa318c5a82cb67ce751d352ef17e9926dd08f8e6b7a720a77170b6f6f018c58ed9f8741cee396dc8e8721f4022c33ef2904815f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirfomene vladimirfomene

Labels
new feature New feature or request
Projects
BDK Wallet
Archived in project
BDK-Bindings
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielnordh @notmandatory @vladimirfomene