Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apply_update instead of determine_changeset + apply_changeset around the code #1081

Closed
danielabrozzoni opened this issue Aug 18, 2023 · 1 comment
Closed

Use apply_update instead of determine_changeset + apply_changeset around the code #1081

danielabrozzoni opened this issue Aug 18, 2023 · 1 comment
Labels
good first issue Good for newcomers
Milestone
1.0.0-alpha.2

Comments

@danielabrozzoni
Copy link
Member

See #1065 (comment)
@danielabrozzoni danielabrozzoni added the good first issue Good for newcomers label Aug 18, 2023
@notmandatory notmandatory moved this to Todo in BDK Wallet Aug 18, 2023
@LagginTimes LagginTimes mentioned this issue Aug 24, 2023
Merged
evanlinjin added a commit that referenced this issue Aug 25, 2023
@evanlinjin
Merge #1092: Use apply_update instead of determine_changeset + `a…
381c560 
…pply_changeset` around the code

c753584 refactor(chain): use `apply_update` instead of `determine_changeset` + `apply_changeset` (Wei Chen)

Pull request description:

  This PR implements #1081

ACKs for top commit:
  evanlinjin:
    ACK c753584

Tree-SHA512: cfb66a427dd76b8d11e07be24de9ba06958cda114b8eec260d492d30fba5a1cecbee2bb3e83b8636f9049eb8e920ad13aa76651a97a01290f53b0c7da8849b41
@evanlinjin
Copy link
Member

Fixed in #1092

@github-project-automation github-project-automation bot moved this from Todo to Done in BDK Wallet Aug 25, 2023
@notmandatory notmandatory added this to the 1.0.0-alpha.2 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
BDK Wallet
Archived in project
Milestone
1.0.0-alpha.2
Development

No branches or pull requests
3 participants
@notmandatory @evanlinjin @danielabrozzoni