-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if no wallet name was provided, use one derived from the descriptor #57
if no wallet name was provided, use one derived from the descriptor #57
Conversation
fd0c3e3
to
7dbc74d
Compare
How about making |
7dbc74d
to
e7d5d27
Compare
@notmandatory Yes, of course. Sometimes the solution is so obvious that I have no clue why I didn't find it myself. Thanks. |
5592a9d
to
773f2db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 773f2db. Code changes looks good to me.
Below are some minor nits.
I think this warrant an addition in changelog. This is probably a breaking change and we should document this.
e9ca941
to
025020d
Compare
025020d
to
adfdd8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK adfdd8c
Verified that each new descriptor is creating its own wallet directory. Updated checksum mismatch error message is being displayed for wallet with same name but different descriptor.
Just one single nit.
adfdd8c
to
292e638
Compare
292e638
to
e52e819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReACK e52e819
Tested it locally. All seem to be working fine.
There are rooms for few improvement but that can be done in a future PR.
This LGTM.
@notmandatory will wait for you take a look before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK e52e819
Works as expected. One suggestion for future PRs is to separate unrelated changes in to different PRs or at least separate commits. In this case the bdk
version upgrade changes were mixed with the wallet name generation changes which made it a little harder to review. But anyway a good usability improvement!
Description
if no wallet name was provided, use one derived from the descriptor
Notes to the reviewers
Is there a better place to use wallet_name_from_descriptor so that the generated name shows up in the unit tests instead of the placeholder?
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing