Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bdk version to 0.25 #132

Closed
wants to merge 1 commit into from
Closed

Bump bdk version to 0.25 #132

wants to merge 1 commit into from

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Nov 30, 2022 •
edited
Loading

Description

Update bdk and bdk-reserves to v0.25 and also change bdk-cli versioning to follow bdk version.

Notes to the reviewers

As part of this change, going forward bdk-cli will publish new releases aprox. one week after bdk releases.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Nov 30, 2022
@notmandatory notmandatory added this to the Release 0.25.0 milestone Nov 30, 2022
This was referenced Nov 30, 2022
Closed
Closed
@notmandatory notmandatory marked this pull request as ready for review December 6, 2022 03:14
@notmandatory notmandatory marked this pull request as draft December 6, 2022 03:15
@notmandatory notmandatory changed the title Bump bdk version to 0.25.0 Bump bdk version to 0.25 Dec 6, 2022
rajarshimaitra
rajarshimaitra reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK f7bbcca

LGTM and ACK on version number according to bdk release.. I think that's more simpler to maintain keep up to date..

@rajarshimaitra
Copy link
Contributor

@notmandatory is this good to go in??

@rajarshimaitra
Copy link
Contributor

closing in favour of #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajarshimaitra rajarshimaitra rajarshimaitra left review comments

Assignees

@notmandatory notmandatory

Labels
None yet
Projects
BDK-CLI Roadmap
Archived in project
Milestone
Release 0.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@notmandatory @rajarshimaitra